perf(engine): parallel storage roots #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-perf
rkrasiuk
force-pushed
the
rkrasiuk/engine-parallel
branch
from
f4db631
to
e96baf2
Compare
rkrasiuk
commented
Sep 11, 2024
rkrasiuk
force-pushed
the
rkrasiuk/engine-parallel
branch
from
f9c572f
to
a7490b8
Compare
rkrasiuk
requested review from
Rjected,
rakita,
joshieDo,
shekhirin,
mattsse,
fgimenez and
gakonst
as code owners
mattsse
requested changes
Sep 12, 2024
Comment on lines
+2174
to
+2175
| let persistence_in_progress = self.persistence_state.in_progress(); | ||
| if !persistence_in_progress { |
There was a problem hiding this comment.
let's inline this and get rid of the tmp var
There was a problem hiding this comment.
temp var cuz it's used later for logging
mattsse
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables parallel storage roots in consensus engine. Parallel calculation will be skipped if persistence is currently in progress or if consistency check fails during calculation, it will fall back to regular one